palkan / active_event_store

Rails Event Store in a more Rails way
MIT License
181 stars 13 forks source link

Updates to use a pipeline mapper and custom domain event transformer #16

Closed Samsinite closed 8 months ago

Samsinite commented 8 months ago

What changes did you make? (overview)

Updates active event store to use a pipeline mapper that uses a custom domain event transformer for dumping/loading the Active Event Store event. Fixes #7

Is there anything you'd like reviewers to focus on?

A sanity check to validate that there is no breaking public API/event format changes.

Checklist

Samsinite commented 8 months ago

Also, I noticed that Rails Event Store also has some rspec matchers. Would you be interested in a separate PR to update the specs to use their have_published matcher and remove this library's have_published_event matcher?

palkan commented 8 months ago

Thanks! Perfect work 👍

Would you be interested in a separate PR to update the specs to use their have_published matcher and remove this library's have_published_event matcher?

I don't think have_published can replace have_published_event; the biggest different is that our matcher doesn't require explicitly specifying the store; actually, a close version would be the publish matcher, since our have_published_event only supports block targets (intentionally).

palkan commented 8 months ago

Released in 1.2.0