Define Rails.configuration.event_store after initialization

palkan / active_event_store

Rails Event Store in a more Rails way

MIT License

182 stars 13 forks source link

Define Rails.configuration.event_store after initialization #18

Closed Samsinite closed 6 months ago

Samsinite commented 6 months ago

This commit updates ActiveEventStore to define Rails.configuration.event_store after the event store has been initialized. Fixes #17

What is the purpose of this pull request?

Defines Rails.configuration.event_store after the event store is initialized, so that the rails event store browser tools (and other tools) should ideally just work out of the box. Fixes #17

Checklist

[ ] I've added tests for this change
[x] I've added a Changelog entry
[ ] I've updated a documentation

Samsinite commented 6 months ago

Any idea what is wrong with sqlite on the 3.0, 3.1, and 3.2 builds? Guessing it is related to the tests using the 2.X release 3.0+, since it doesn't run on Ruby 2.7.

Edit: Figured it out, looks like active record pinned it to ~> 1.4, there appears to be an update for 7.1 to run on 2.x, but it hasn't been released yet I believe.

palkan commented 6 months ago

Looks good 👍 Thanks!

P.S. I fixed the sqlite/Rails 8 problems in master; should be green after the merge.