Closed storkvist closed 4 years ago
@storkvist Looks good! Thanks!
Could you please add Ruby 2.7 to the Build action matrix?
Could you please add Ruby 2.7 to the Build action matrix?
Yes, of course. Sorry, I missed that at first.
Also, I noticed there are 2 linter errors from Lint/NonDeterministicRequireOrder
. Maybe I can fix them in my PR with adding #sort
?
Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].sort.each { |f| require f }
Or should I leave it as is?
Or should I leave it as is?
Let's leave. I'll take care of it later.
Thanks!
Change-Id: I05162bc511252304a89b80b78a0ad2ce264e4d47
What is the purpose of this pull request?
Fixes #48
Remove warnings about using the last argument as keyword arguments.
What changes did you make? (overview)
Convert hash to keyword arguments in several method calls.
Is there anything you'd like reviewers to focus on?
Checklist