Switch to fix - Githubissues

palkan / logidze

Database changes log for Rails

MIT License

1.59k stars 74 forks source link

Switch to fix #218

Closed miharekar closed 1 year ago

miharekar commented 1 year ago

Fixes #217

Additionally, I've added a log_data check in switch_to!. When append is false the check would happen in at_version!, but when it's true the method would fail.

Now we always check and raise on nil.

Checklist

[x] I've added tests for this change
[x] I've added a Changelog entry
[ ] I've updated a documentation (Readme)

miharekar commented 1 year ago

The markdown failures are because of this https://github.com/markdownlint/markdownlint/pull/373

I disagree with this PR and would either change MD007 to indent 2 or disable it. But it's outside of this PR scope and completely up to you 😅

As for Ruby 2.5 failures I have no ideas and am installing it locally so I can see what's going on.

UPD: Ah, it's probably block passed to to_h.

palkan commented 1 year ago

Thanks! Will prepare a release shortly