warmup logic fix - Githubissues

palkan / n_plus_one_control

RSpec and Minitest matchers to prevent N+1 queries problem

MIT License

553 stars 20 forks source link

warmup logic fix #58

Closed akostadinov closed 2 years ago

akostadinov commented 2 years ago

What is the purpose of this pull request?

Fixes issue that with minitest the warmup lambda can't be used, only a method.

What changes did you make? (overview)

current logic is that if warmup was specified or a method exists, then use the method. It should be use warmup lambda when specified or method if is exists.

Checklist

[x] I've added tests for this change
[ ] I've added a Changelog entry
[ ] I've updated a documentation

palkan commented 2 years ago

Thanks! Let's make RuboCop happy and we're good to merge.

akostadinov commented 2 years ago

Updated, thanks!

akostadinov commented 1 year ago

@palkan , would you push a new release sometime soon?