Fix Haml template generation

palkan / view_component-contrib

A collection of extension and developer tools for ViewComponent

MIT License

369 stars 22 forks source link

Fix Haml template generation #36

Closed jayshepherd closed 1 year ago

jayshepherd commented 1 year ago

What is the purpose of this pull request?

The Haml option was not using the correct name or Haml template content.

What changes did you make? (overview)

Renamed the filename to '...html.haml.tt'
Updated the template content to be Haml compatible

Is there anything you'd like reviewers to focus on?

Checklist

[ ] I've added tests for this change
[ ] I've added a Changelog entry
[ ] I've updated a documentation

palkan commented 1 year ago

Thanks!

brodienguyen commented 1 year ago

@palkan Hi there. Just want to confirm if this change is going to be included in the upcoming release. I have check the current script hasn't been updated so the HAML template generator is still broken

palkan commented 1 year ago

I have check the current script hasn't been updated

You mean RailsBytes script? I've just published the new one; the change is there.

brodienguyen commented 1 year ago

I have check the current script hasn't been updated

You mean RailsBytes script? I've just published the new one; the change is there.

Yes I meant the RailsBytes script. Sorry I did make it clear before. Thanks heaps for your time to contribute in this project and make the view_component neater.