Key management package improvement

palladians / pallad

Progressive Mina Protocol Wallet

https://pallad.co/

Apache License 2.0

26 stars 10 forks source link

Key management package improvement #132

Closed teddyjfpender closed 9 months ago

teddyjfpender commented 9 months ago

Describe changes

This PR improves the key-management package, specifically the scope mentioned in https://github.com/palladians/pallad/issues/131.

TODO:

[x] Separate out the SpecificArgs -- we don't need the same type for both the initialisation of a key agent and for key-agent operations.

teddyjfpender commented 9 months ago

The changes to the MinaSigningOperations are optional and depend on an optional field operation in the MinaSpecificArgs type. This is to collectively review whether the proposed changes warrant breaking changes to the signing operation API.

teddyjfpender commented 9 months ago

@mrcnk Let's merge this PR here. With these changes, we can make the required improvements to the vault and minimise the API size as we refactor the vault.