palladians / pallad

Progressive Mina Protocol Wallet
https://pallad.co/
Apache License 2.0
25 stars 8 forks source link

Add Word Number Labels to Mnemonic Inputs in Wallet Restoration Flow #202

Closed aliraza556 closed 3 weeks ago

aliraza556 commented 3 weeks ago

Problem:

closes: #190

Issue ticket number and link:

Evidence:

https://www.loom.com/share/7cc9a86b55ce4457ba6b943530f5b633

image

Acceptance Criteria

deepsource-io[bot] commented 3 weeks ago

Here's the code health analysis summary for commits 678ec59..b789a36. View details on DeepSource β†—.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScriptβœ… SuccessView Check β†—

πŸ’‘ If you’re a repository administrator, you can configure the quality gates from the settings.
aliraza556 commented 3 weeks ago

Hi @mrcnk Please review this PR.

mrcnk commented 3 weeks ago

Hi @aliraza556, it's almost perfect, can you just make sure the label has enough of spacing for double digit numbers? It's a little too close. CleanShot 2024-08-21 at 11 10 04@2x When it's fixed I'm gonna merge and let you know how we do bounty pay outs with https://astromina.org/.

aliraza556 commented 3 weeks ago

When it's fixed I'm gonna merge and let you know how we do bounty pay outs with https://astromina.org/.

@mrcnk Ok I fix it and then ping you.

aliraza556 commented 3 weeks ago

Hi @mrcnk, Please merge this PR.

image

aliraza556 commented 3 weeks ago

Hi @aliraza556, it's almost perfect, can you just make sure the label has enough of spacing for double digit numbers? It's a little too close. CleanShot 2024-08-21 at 11 10 04@2x When it's fixed I'm gonna merge and let you know how we do bounty pay outs with https://astromina.org/.

@mrcnk Fixed

mrcnk commented 3 weeks ago

@aliraza556 now it's the other way around, the single digit number labels are too close πŸ˜…

CleanShot 2024-08-21 at 14 08 00

aliraza556 commented 3 weeks ago

@aliraza556 now it's the other way around, the single digit number labels are too close πŸ˜…

CleanShot 2024-08-21 at 14 08 00

ok I try to fix it

aliraza556 commented 3 weeks ago

@mrcnk Done:

image

mrcnk commented 3 weeks ago

@aliraza556 please format the code with "pnpm format:unsafe" and push again, that should make it complete and bounty will be on the way to you

aliraza556 commented 3 weeks ago

@mrcnk Please approve the workflows