Portfolio value change calculation is broken when using Mina values

palladians / pallad

Progressive Mina Protocol Wallet

https://pallad.co/

Apache License 2.0

26 stars 10 forks source link

Portfolio value change calculation is broken when using Mina values #204

Closed aliraza556 closed 2 months ago

aliraza556 commented 2 months ago

Problem:

When using Mina values on Dashboard, the daily change +0.02 (24h) is broken, displaying pretty much the same value all the time.

closes: #198

Issue ticket number and link:

Ticket Number: [ 198 ]
Link: [ https://github.com/palladians/pallad/issues/198 ]

Acceptance Criteria

[x] The value reflects an actual fiat change, but in Mina.

aliraza556 commented 2 months ago

Hi @mrcnk, Please review this PR.

deepsource-io[bot] commented 2 months ago

Here's the code health analysis summary for commits ee3f2ee..dc6ed65. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
JavaScript	✅ Success		View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

mrcnk commented 2 months ago

Hey, just checked and:

First there's an additional, unnecessary minus for negative values.
Value is still fixed at -0.03, no matter of portfolio size.

aliraza556 commented 2 months ago

Hey, just checked and:

First there's an additional, unnecessary minus for negative values.

Value is still fixed at -0.03, no matter of portfolio size.

@mrcnk Please review this PR: I have fixed

mrcnk commented 2 months ago

@aliraza556 It's now displaying fiat values both for fiat and Mina. For Mina it should display Mina value, so if for example the price of Mina is 50c, it should be:

Mina Change Value = Fiat Change Value / Fiat Price
In example: Fiat Change Value = 100 USD, Fiat Price = 50c
Mina Change Value = 100 USD / 0.5
Mina Change Value = 200 Mina

aliraza556 commented 2 months ago

@aliraza556 It's now displaying fiat values both for fiat and Mina. For Mina it should display Mina value, so if for example the price of Mina is 50c, it should be:
Mina Change Value = Fiat Change Value / Fiat Price
In example: Fiat Change Value = 100 USD, Fiat Price = 50c
Mina Change Value = 100 USD / 0.5
Mina Change Value = 200 Mina

@mrcnk Please review it i have fixed

mrcnk commented 2 months ago

@aliraza556 it's working fine now, can you just format the code and push again?

aliraza556 commented 2 months ago

@aliraza556 it's working fine now, can you just format the code and push again?

@mrcnk Ok

aliraza556 commented 2 months ago

@mrcnk Done