01-set-up-GKE-clusters.sh fails in envs where default network isnt automatically created

palladius / clouddeploy-platinum-path

Cloud Build + Cloud Deploy from the ground up

Apache License 2.0

7 stars 11 forks source link

01-set-up-GKE-clusters.sh fails in envs where default network isnt automatically created #11

Open willisc7 opened 2 years ago

willisc7 commented 2 years ago

Script currently assumes default network exists and fails if it doesn't. It might be worth adding gcloud compute networks create default to the script.

Also, the command takes a while to run so I would probably use --async and then have them run a "watch" command

palladius commented 2 years ago

ouch. Thanks.

If you dont mind I'd leave it in sync though. worst case scenario you ctrlC and run twice .

can you pinpoint WHERE you would put it in the code?