search

pallassgj / bpipe

Automatically exported from code.google.com/p/bpipe
0 stars 1 forks source link

clean git checkout does not compile due to missing libraries #87

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. git clone https://code.google.com/p/bpipe/
2. cd bpipe
3. gradle dist

What is the expected output? What do you see instead?
expected output: BUILD SUCCESSFUL
instead: BUILD FAILED (unable to find javax.mail packages and Gridgain 
libraries)

What version of the product are you using? On what operating system?
current git master (dc578d86f47f11422efb13857577a666f58a3762)

Discussion:

I was able to figure out from the comments in build.gradle that the missing 
Gridgain library is because they no longer provide a maven repo for download, 
but require a user to register/login to download the client jar file. This 
provides a barrier to entry for people starting to use bpipe, especially if 
they have no interest in Gridgain. Would you be willing to have Gridgain 
support optional? I'm not sure if this is the best way to fo this in gradle, 
but the attached patch will exclude the Gridgain-related classes unless 
'-PincludeGridgain' is passed to gradle.

The second issue is the java mail api (mail.jar). If it is really incompatible 
with your intended license (they use GPL with classpath exception or CDDL-- 
either available), then would you consider finding another way to perform mail 
notifications or making this code optional as well? The patch below 
incorporates mail.jar from mavenCentral so that things will compile.

Original issue reported on code.google.com by bradford...@gmail.com on 3 Dec 2013 at 2:07

Attachments:

GoogleCodeExporter commented 9 years ago 
As an alternative to providing a gradle option on the command line, the patch 
below just looks to see if there is a local-lib/gridgain-*.jar file present and 
if not excludes compilation of GridGain support.

Original comment by bradford...@gmail.com on 22 Jan 2014 at 6:55

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi Bradford, I wish I had checked your comments since I just checked in patch 
for this myself. Thanks so much for contributing them. Would be great if you 
could double check this is resolved for you with a fresh checkout.

Original comment by ssade...@gmail.com on 23 Jan 2014 at 1:36