search

pallet / ritz

SWANK and nREPL servers for clojure providing JPDA based debuggers
318 stars 33 forks source link

Rename nrepl-mode to nrepl-repl-mode to match upstream nrepl.el #110

Closed dgtized closed 7 years ago

dgtized commented 11 years ago

nrepl.el summarily renamed nrepl-mode to nrepl-repl-mode, so this should fix compatibility problems referencing nrepl-mode var's.

This appears to be the cause of the following bug report: https://groups.google.com/forum/#!topic/nrepl-el/smnLFjxhBNs

dgtized commented 11 years ago

Also related is https://github.com/clojure-emacs/nrepl.el/issues/375.

darth10 commented 11 years ago

Hah... This failed the tests, but after running them all successfully (wtf?). I'm not sure if the build failed due to this commit, since other pull requests are also failing. Check https://travis-ci.org/pallet/ritz/pull_requests for more info.

dgtized commented 11 years ago

That seems like it's caused by something else. It actually looks like it's not done testing, just trying to install an artifact locally, and fails due to not being able to find filterv. That's in debugger / clojure code, not in the elisp interface. I think that's because https://github.com/pallet/ritz/blob/develop/repl-utils/project.clj#L7, is for Clojure 1.2.1, and filterv is from 1.4.0. See #111

tvaughan commented 11 years ago

FWIW I made these changes locally and they work just fine for me.