search

palletops / lein-uberimage

A Leiningen plugin to generate a docker image that runs a project's uberjar.
Eclipse Public License 1.0
136 stars 10 forks source link

baseimage should be specified in project.clj for build consistency #13

Closed davesann closed 10 years ago

davesann commented 10 years ago

Rather than using a cmd line option the base image might be better specified in the project file. This allows more consistency of build.

hugoduncan commented 10 years ago

Definitely a good idea to be able to specify this in project.clj. I would keep the command line option though.

hugoduncan commented 10 years ago

The :base-image key should already work for this actually.

davesann commented 10 years ago

I thought that. But I tried a few combinations and it did not work. After staring at the code for a while, I came to the conclusion that it is most likely overwritten by the default being set by parse-opts. I didn't dig further to confirm that.

Agree. keep cmd line too.

hugoduncan commented 10 years ago

Your code staring yielded more correct results than mine - I think you are correct.