samuelhwilliams
commented
4 days ago I'm starting work on this in a branch/PR on my fork: https://github.com/samuelhwilliams/flask-admin/pull/1.
Going to just dump some notes here as I work through it - please bear with as a bunch of this will be stuff I haven't touched before.
I'm using Flask-SQLAlchemy as the reference project in terms of files/structure to copy, etc.
- I've migrated
requirements-dev.txttorequirements/tests.in, and not pip-compiled that to atests.txtbecause I think each Python version tox runs the tests in needs to pick appropriate versions internally - there's not a single set of dependencies that I think we can freeze that would work for all python versions we're matrix testing. flask-sqlalchemyhas adocsdirectory,flask-adminhas adocdirectory. I'm not migrating these files because it's a huge changeset. We can do it in a separate PR if we thing it's worth doing.- The docs also need updating to the Pallets theme; possibly some fairly chunky changes needed to do this? I think it's best to do this separately.
flask-sqlalchemyhas amainbranch;flask-adminis still using amasterbranch.- I've copied across the
typingtarget fromflask-sqlalchemybut I don't imagine it will pass because it doesn't appear there's been typing tests on the current repo. flask-sqlalchemyhas apy-mintox target and somerequirements-skipfiles; do we need similar here? Not a thing I've seen elsewhere/am familiar with.- I've had to manually tweak a couple of minor versions of packages in the pip-compiled files to play together (
packaging,babel,typing-extensions)
Abdur-rahmaanJ
@samuelhwilliams working on it.