search

pallets-eco / flask-admin

Simple and extensible administrative interface framework for Flask
https://flask-admin.readthedocs.io
BSD 3-Clause "New" or "Revised" License
5.69k stars 1.56k forks source link

Standardise project structure for the Pallets Ecosystem #2436

Closed samuelhwilliams closed 1 day ago

samuelhwilliams commented 4 days ago

Copies across, and then customises, the Pallets Ecosystem standard project structure from Flask-DebugToolbar

The tests throw a number of warnings, which are now being flagged as errors because of the standard project config. I've suppressed a number of these where it feels appropriate, but probably worth discussing if it's right to suppress them here or if we should immediately fix them. I suspect a number of them should be addressed in separate issues, eg things around DeprecationWarnings.

The test requirements file is a lot more complex for this project than for FDT, so I'm not sure we can freeze it in the same way. I have kept a tests.in file, with the existing test_requires from the original setup.py; not sure what we would want to do about this.

I suspect we may also need to disable the typing check and address that in a separate PR.

fixes: https://github.com/pallets-eco/flask-admin/issues/2435

aenglander commented 1 day ago

LGTM. Now, once merged, we need to fix CI/CD issues!

@aenglander

@Abdur-rahmaanJ The only thing that seems to need fixing is typing. If the library isn't ready for typing checks, the test should be disabled, and a ticket should be created to add type support.