search

pallets-eco / flask-admin

Simple and extensible administrative interface framework for Flask
https://flask-admin.readthedocs.io
BSD 3-Clause "New" or "Revised" License
5.8k stars 1.58k forks source link

Plan for next release - v2.0 #2451

Open samuelhwilliams opened 4 months ago

samuelhwilliams commented 4 months ago

Opening this to think about/plan for the next release, which I propose should encompass:

Plus these changes merged since:

Plus these target changes:

And potentially any other small PRs we think we can get in fairly easily.

When the changeset is locked

Because of those last target changes, we'd need to do this as a major version bump.

@aenglander @Abdur-rahmaanJ - thoughts?

Abdur-rahmaanJ commented 4 months ago

@samuelhwilliams How about 1.7?

samuelhwilliams commented 4 months ago

What makes you suggest 1.7?

I think standard practice would be to assume Semantic Versioning, which says breaking changes should be a major versioning bump (ie 1 to 2). Dropping python 3.7 and dropping flask-babelex are breaking changes, so I think V2 would be the logical step to me.

Happy to hear counter arguments though.

Abdur-rahmaanJ commented 4 months ago

Good then did not see any breaking changes from the description. Good 👍 for a 2.0.

hasansezertasan commented 4 months ago

I believe #2407 is suitable for the next release.

samuelhwilliams commented 4 months ago

Flask-Babel and host_matching PRs are up. Will leave open for feedback for a few days.

Aiming to do a 2.0.0rc0 release next week ish.

samuelhwilliams commented 4 months ago

Right. We have a bunch of stuff merged - I'm thinking of doing a 2.0.0rc0 release, maybe tomorrow. That would mean (in my head) no more feature merges - only bug fix merges - until 2.0.0 proper is released.

Do we think we want to try to get anything else simple/quick in urgently before the rc0 release?

samuelhwilliams commented 4 months ago

@cjmayo Have added SQLAlchemy 2/Flask 3/WTForms 3 as target changes for a 2.0.0 release, if you're happy with that? I'm happy to try to help where needed, although it looks like maybe you've got it covered.

princerb commented 4 months ago

There are more configuration changes too, like when creating Admin instance, so I guess it is fair to think about the next release tagging with 2.0.0

cjmayo commented 4 months ago

@cjmayo Have added SQLAlchemy 2/Flask 3/WTForms 3 as target changes for a 2.0.0 release, if you're happy with that? I'm happy to try to help where needed, although it looks like maybe you've got it covered.

I'm happy. I think I have enough - at least to get the tests to pass (I have been using these patches for a while with the new dependencies).

samuelhwilliams commented 4 months ago

Would you like to weigh in/mind weighing in on https://github.com/pallets-eco/flask-admin/pull/2476? It deals with dependencies too, specifically making it more explicit what dependencies are required for certain features and what versions we support. It doesn't do much work bumping dependencies, but should make it easier to test+validate dep bumps in the future.

samuelhwilliams commented 4 months ago

Ok - the target date is obviously slipping a bit, but I think it's useful to get a few more of these things in before doing some kind of pre-release.

Notably:

ElLorans commented 3 months ago

Can we have in the docs a suggested approach for considering client's timezone when submitting datetime fields? I am referring to https://github.com/pallets-eco/flask-admin/issues/1892

samuelhwilliams commented 3 months ago

@ElLorans would you like to put up a PR adding some information and/or an example? I think specifically an example would be super helpful :)

ElLorans commented 3 months ago

@samuelhwilliams just opened https://github.com/pallets-eco/flask-admin/pull/2502

samuelhwilliams commented 3 months ago

Since the changes merged so far for v2.0.0 include a lot of dependency bumps, I think it also makes sense to switch the S3 admin interface over from using boto to boto3, and the azure-blob-storage interface to using azure-storage-blob>=12. So will try to include those as well.

pajusmar commented 3 months ago

Thank you for all the hard work on the new release. I noticed that while there are many exciting updates mentioned, there hasn't been any discussion about the state of translations. There was an earlier issue (#1950) that raised concerns about updating translations, and I was wondering if this has been addressed in the latest release or if there are any plans to do so.

samuelhwilliams commented 3 months ago

Hey @pajusmar - it's a good question. I've asked it on the pallets-eco discord to work out what our plan is with translations... 👀

samuelhwilliams commented 2 months ago

Going to publish v2.0.0a0 shortly - this is an pre-release so would be grateful to anyone able to test it out and see what bugs there may be 🙏

It's not feature-complete yet necessarily, and I still think it'd be nice to get updates to fileadmin for AWS and Azure in, but I just haven't had time yet. Anyone able to contribute those changes (essentially migrating fileadmin.s3 to use boto3, and updating fileadmin.azure to use azure-storage-blob>=12)

samuelhwilliams commented 2 months ago

v2.0.0a0 is now published

pajusmar commented 2 months ago

Hey @pajusmar - it's a good question. I've asked it on the pallets-eco discord to work out what our plan is with translations... 👀

@samuelhwilliams, I saw on Discord that I should submit a pull request to modify translations.

I would really like to change one word. "Add" is a verb, not a noun, as it's currently translated into Estonian. The correct translation is "Lisa". Will it make it to 2.0, or are we past the string freeze?

samuelhwilliams commented 2 months ago

Nope, by all means put up a PR please. Changes now would still go into V2.0.0 :)

LeXofLeviafan commented 2 months ago

Out of curiosity – is there any progress on #1974? (Or at least any information about its causes?)

It just seems kind of bizarre that "View record" & "Edit record" button tooltips are translated, but "Delete record" is not :sweat_smile:

ElLorans commented 2 months ago

Out of curiosity – is there any progress on #1974? (Or at least any information about its causes?)

It just seems kind of bizarre that "View record" & "Edit record" button tooltips are translated, but "Delete record" is not 😅

Yes that's annoying for sure

ElLorans commented 1 month ago

Out of curiosity – is there any progress on #1974? (Or at least any information about its causes?)

It just seems kind of bizarre that "View record" & "Edit record" button tooltips are translated, but "Delete record" is not 😅

This is fixed in https://github.com/pallets-eco/flask-admin/pull/2526#issuecomment-2395368678 . @samuelhwilliams can we release 2.0? Are there still DeprecationWarnings?

samuelhwilliams commented 1 month ago

I will (try to) do a 2.0.0a1 soon. I think there's probably still more stuff that makes sense to do for a 'proper' v2 release - updating both of the fileadmin implementations for a start.

samuelhwilliams commented 1 month ago

I've done a v2.0.0a1 now that includes those changes and compatibility support for wtforms v3.2+

samuelhwilliams commented 1 month ago

I do still think it would be good to get in updates for s3/ABS before doing an official release of v2.0.0, but I also am aware that it's taking quite a chunk of time for me to have time for that and there's maybe not a huge amount of appetite from anyone else to add it. :(

Possibly also good to drop python 3.8 and add python 3.13, too.

samuelhwilliams commented 1 month ago

Ok I found time to do boto->boto3, so just azure blob storage to go really 🤞

samuelhwilliams commented 1 month ago

that's now available as v2.0.0a2

pamelafox commented 2 weeks ago

@samuelhwilliams Is there an issue about azure blob storage? I can probably tackle that. Just wondering if there were known issues about upgrading, or just general SDK interface changes.

samuelhwilliams commented 2 weeks ago

I'm not aware of any issues specifically - but that is mostly because I haven't looked closely yet. It may well just be SDK interface changes. Would be very grateful if you wanted to tackle it, it's really the last big blocker for an official v2 release, I think 👀

If there isn't an obvious issue open, please feel free to open one to track it 🙏

pamelafox commented 6 days ago

PR for Azure storage upgrade: https://github.com/pallets-eco/flask-admin/pull/2573/files