Fixed scrollbar issues

[caffeinatedMike]

Fixes #181 where the scrollbar would not show on any page other than the sqlalchemy_select.html template. The scroll classname is now properly named and applied throughout all panel templates as flDebugScroll. I've also added a 10px bottom padding to show the end of the inner panel (for aesthetics sake).

[caffeinatedMike]

Pinging @nickjj

[nickjj]

Hi,

Thanks for the PR, would it be possible to record a quick video of the before / after? This will make it easier for others to see what's happening visually.

[florianm]

Just wanted to leave a note to say thanks for the fix, @caffeinatedMike! This PR comes just in time for a major CKAN release (2.10), and flask-debugtoolbar is immensely useful for CKAN developers.

[caffeinatedMike]

@nickjj unfortunately, due to time constraints I'm not able to do so. However, if you'd like to reproduce the issue you can do so by changing the height of the browser when a panel is shown. Before the fix, both the panel on the left and toolbar on the right would not show all their contents. After applying the changes in this PR you can reach the overflowing content on both of these via scrollbars that only show when there is overflowing content.

@florianm Happy to help! I'm always glad to be able to contribute to the open source tools I use.

[caffeinatedMike]

@nickjj Finally had a moment to record the before/after. Hope this helps! LGTM!

https://user-images.githubusercontent.com/22151742/183672020-09764e45-5eab-4674-b948-8b6736709e8a.mp4

[nickjj]

Hey, thanks for making the video. This looks good. @jeffwidman, do you have any last minute feedback before merging this in?

[nickjj]

Thanks for the contribution, it'll make its way into the next release.

[florianm]

Thanks @nickjj! Do you have a rough timeline on the next release? This could make its way into the upcoming CKAN 2.10 release.

[nickjj]

There's no ETA but there's also https://github.com/flask-debugtoolbar/flask-debugtoolbar/pull/183 which is close to being ready to be merged.

[lmiguelvargasf]

@nickjj , any updates on the release date?

[nickjj]

@lmiguelvargasf sort of seeing if https://github.com/flask-debugtoolbar/flask-debugtoolbar/issues/185 will materialize into a PR.

[samuelhwilliams]

It would be super to see a release go out soon 🤞 - this bug seems to have been hanging around a while 🥲

[Gauravp-NEC]

Thanks for the contribution, it'll make its way into the next release.

@nickjj , What is the planned date of next release?

[nickjj]

I think we're pretty close to being able to ship a new release. We're still transitioning to a new CI set up and don't have any automation in place to run, test and ship new releases. @jeffwidman do you want to do 1 last manual release or would you like some of your open issues (#193, #192, #191, #190, #188) be completed first?

[jeffwidman]

I'm fine either way, but given those issues will probably require some work I'd say ship a manual release to get the bugfixes live for folks, then can cleanup the CI workflows as we have time (which seems to always be in short supply these days with young kids!)

[caffeinatedMike]

Could definitely use a manual release because this feature has caused the extension to be unusable in my projects for about 4 months now.

[jeffwidman]

Yah, I hear you. I started to cut a release and ran into #197 / #198, those should both probably land first to make the process slightly more straightforward.

[Gauravp-NEC]

@nickjj , Any update on date of next release?