pallets-eco / flask-debugtoolbar

A toolbar overlay for debugging Flask applications
https://flask-debugtoolbar.readthedocs.io
BSD 3-Clause "New" or "Revised" License
952 stars 146 forks source link

Flask-SQLAlchemy 3 compatibility #185

Closed davidism closed 2 years ago

davidism commented 2 years ago

Flask-SQLAlchemy 3 was just released, here's the changelog: https://flask-sqlalchemy.palletsprojects.com/en/3.0.x/changes/#version-3-0-0

Relevant changes for Flask-DebugToolbar are:

The renames/moves currently show deprecation warnings, but will be removed in 3.1.

nickjj commented 2 years ago

Thanks a lot for the heads up David.

This would be a great first PR if someone wants to take this on. One thing to consider is we'd like to keep backwards compatibility with SQLAlchemy 2.X for quite some time before dropping it. An ideal solution would work with both.

Dosenpfand commented 2 years ago

Hi @nickjj, I openend pull request #186 to address this issue.

nickjj commented 2 years ago

186 has been merged, thanks a lot!