search

pallets-eco / flask-debugtoolbar

A toolbar overlay for debugging Flask applications
https://flask-debugtoolbar.readthedocs.io
BSD 3-Clause "New" or "Revised" License
952 stars 146 forks source link

Remove the use of before_first_request #218

Closed greyli closed 1 year ago

greyli commented 1 year ago

This decorator has been removed in Flask 3.0.

jeffwidman commented 1 year ago

Great question.

FWIW, if it's painful to retain backwards compatibility, don't be afraid to also drop support for Flask < 3.x. Most of those users will be fine with the older releases of Flask-DebugToolbar, and the ones who are currently broken are on newer Flask. Plus given the limited maintenance time this project receives, better to fix forward and start from a cleanish slate if needed. Whatever seems better to you two.

greyli commented 1 year ago

This change won't break the Flask 2.x and Flask 1.x compatibility.

greyli commented 1 year ago

Merged. I updated the test database URL to the in-memory SQLite database so that it will work on Windows.