search

pallets-eco / flask-jwt

JWT (JSON Web Tokens) for Flask applications
MIT License
564 stars 177 forks source link

Add CORS support #21

Closed Ktl-XV closed 10 years ago

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-9.09%) when pulling b0d29f0532e6863cca54d596e8f47aaf457a6aa6 on Ktl-XV:master into 7abef49a4794d0b639733c2331fa3fa5583f79ad on mattupstate:master.

svenstaro commented 10 years ago

Might wanna add a test for that I suppose.

mattupstate commented 10 years ago

I'm not so sure I want to add CORS features to this extension yet. There are plenty of other ways to add CORS headers to your application.

jayzeng commented 10 years ago

I don't think this is a good idea, anyone can roll in his own or use flask-cors. Adding cors as part of this extension makes this extension less usable.

jarmani commented 10 years ago

Agreed. I don't see any added value over flask-cors, there is nothing specific to JWT.

tigrus commented 8 years ago

Can you add documentation on using CORS with /auth handler?

hyzhak commented 7 years ago

@mattupstate good point, why don't add documentation about using CORS? It is very common case for authrization endpoints.