pallets-eco / flask-openid

Flask-OpenID adds openid support to flask applications
Other
234 stars 77 forks source link

after_login handler redirects to url with empty anchor #32

Closed tomasra closed 9 years ago

tomasra commented 10 years ago

Hello,

In every flask-openid usage example so far I've noticed that successful login handler (decorated with @oid.after_login) always redirects to URL with a hash symbol at the end, for example: http://localhost:5000/#

In one very specific situation involving CKEditor this is causing some problems: http://ckeditor.com/forums/CKEditor/Scrolling-problem-when-using-empty-anchor-in-URL

Is there any way to prevent hash from being added to redirect URL or is there a particular reason for such behaviour? Not sure if this is related to flask-openid or the flask framework itself, but any feedback would be appreciated.

puiterwijk commented 10 years ago

This is probably specific to the websites you have been using, as there is no code at all in flask-openid that does this.

Also, the included example/example.py script does not do this either.

Do you have an example implementation that does show this behavior?

tomasra commented 10 years ago

Just checked this one more time with another browser (Firefox) and strangely the problem was gone. Looks like this happens only with Chrome, I've tried example.py script and sample project from flask mega-tutorial: http://blog.miguelgrinberg.com/post/the-flask-mega-tutorial-part-v-user-logins

puiterwijk commented 9 years ago

I was unable to reproduce this, even with the scripts on the mega-tutorial. Does this still happen to you?

puiterwijk commented 9 years ago

Since I haven't heard back on this for quite some time, I'm going to close this. If you hit it again, feel free to re-open.