search

pallets-eco / flask-openid

Flask-OpenID adds openid support to flask applications
Other
236 stars 77 forks source link

Replaced deprecated werkzeug.urls.url_quote() with urllib.parse.quote() #71

Closed TheZoc closed 5 months ago

TheZoc commented 1 year ago

Fixes #70

frantisekz commented 10 months ago

Backported to Fedora downstream, works fine, thanks!

JonathanBrenner commented 9 months ago

Would love to see this fix integrated!

TheZoc commented 6 months ago

Small nudge in here, hoping a maintainer takes a look at this :)

potiuk commented 5 months ago

I have completely forgot that I've been added as maintainer here to be able to make such releases. @TheZoc - can you please also add urllib as dependency in setup.py (install_requires?). I think I can make a release of it right after.

potiuk commented 5 months ago

(sorry - I've been added as maintainer to remove some very old setup2to3 dependencies only and I have not been paying attention to it @TheZoc ).

TheZoc commented 5 months ago

Hi @potiuk, glad to hear back from you! I believe it's not necessary to change setup.py, since urllib is part of Python since v3.3

Please let me know if it needs any additional changes :)

potiuk commented 5 months ago

I believe it's not necessary to change setup.py, since urllib is part of Python since v3.3

Right 🤦 . Somehow I thought it's requests :)

potiuk commented 5 months ago

BTW. Note that OpenID is a very old protocol (it's not OpenID-connect) and almost nothing supports it, and it has some known security vulnerabilities. So not sure why you need it..

potiuk commented 5 months ago

Released it https://pypi.org/project/Flask-OpenID/1.3.1/ - let me know if that fixed your issue.