pallets-eco / flask-security-3.0

Quick and simple security for Flask applications
MIT License
1.63k stars 512 forks source link

RethinkDB support #388

Open zbyte64 opened 9 years ago

zbyte64 commented 9 years ago

If a pull request was sent to add RethinkDB support, would it be accepted (assuming it is up to par)?

I found a gist that implements support though it would need to be adapted to conform to how it is done in datastores.py: https://gist.github.com/BrianHicks/9054310

jonafato commented 9 years ago

This seems like a nice addition. There's currently a pending pull request for Pony ORM, and it seems that the only rejected datastore addition was for a proprietary and fully managed datastore. RethinkDB is open source with official Python support, so I don't see many arguments against it.

zbyte64 commented 9 years ago

It looks likes I will need to modify .travis.yml to install rethinkdb:

https://github.com/travis-ci/travis-ci/issues/2048

http://docs.travis-ci.com/user/installing-dependencies/#Installing-Packages-from-a-custom-APT-repository

pdonorio commented 9 years ago

+1 for rethinkdb :+1:

drcongo commented 9 years ago

:+1:

xorgonix commented 9 years ago

+1 for rethinkdb

sonnybaker commented 8 years ago

:+1: too

drcongo commented 8 years ago

I've started work on a little thing that allows Flask-Security to be used with RethinkDB with Schematics supplying the model definitions, figured I'd post it here for those interested in using RethinkDB with Flask-Security. It's working, but still considered pre-alpha so if anyone wants to contribute they'd be more than welcome.

https://github.com/hactar-is/frink/

http://frink.readthedocs.org/en/latest/ (I've not managed to get RtD to generate the autoclass stuff yet but if you generate the docs locally it'll work)

drcongo commented 8 years ago

Update, it's now on PyPI if you fancy trying it out: https://pypi.python.org/pypi/frink

hueniverse commented 8 years ago

For travis support, just add:

addons:
  rethinkdb: "2.3"