search

pallets-eco / flask-security

Quick and simple security for Flask applications
MIT License
635 stars 155 forks source link

Clarify `SECURITY_DEPRECATED_HASHING_SCHEMES` #1003

Closed savchenko closed 2 months ago

savchenko commented 2 months ago

Make configuration explicit. I also wonder if it's worth setting by default:

SECURITY_DEPRECATED_HASHING_SCHEMES = ["auto"]
SECURITY_HASHING_SCHEMES = ["sha256_crypt"]
savchenko commented 2 months ago

How about we just change 'SECURITY_DEPRECATED_HASHING_SCHEMES to ["auto"] - that seems the best/easiest.

Sounds good. Just need to make sure that sha256_crypt is the first one, order is important.

Maybe include link https://passlib.readthedocs.io/en/stable/lib/passlib.context.html as well, I had to read it to comprehend what's actually going on.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.49%. Comparing base (25ad68d) to head (ba007b7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1003 +/- ## ======================================= Coverage 98.49% 98.49% ======================================= Files 37 37 Lines 4777 4777 ======================================= Hits 4705 4705 Misses 72 72 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jwag956 commented 2 months ago

fixed with #1009