pallets-eco / flask-security

Quick and simple security for Flask applications
MIT License
635 stars 155 forks source link

Try a different approach to typing datastores. #1008

Closed jwag956 closed 2 months ago

jwag956 commented 2 months ago

Rather than define our own User model (just for typing) - change the annotations to use UserMixin and as part of typing define each possible member and type.

Add annotations to view_scaffold.py - as a test for the new datastore annotations.

add pyright config to pyproject.toml - it throws tons of errors - but view_scaffold not passes.

closes #1001

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.40%. Comparing base (394e86c) to head (9ca3f37).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1008 +/- ## ======================================= Coverage 98.40% 98.40% ======================================= Files 37 37 Lines 4755 4758 +3 ======================================= + Hits 4679 4682 +3 Misses 76 76 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.