pallets-eco / flask-security

Quick and simple security for Flask applications
MIT License
635 stars 155 forks source link

Improve /reset and /confirm w.r.t. GENERIC_RESPONSES and additional f… #815

Closed jwag956 closed 1 year ago

jwag956 commented 1 year ago

…orm args.

Title says it all - very confusing (UX) results when adding a form arg (e.g. captcha) so the above forms and having an error.

closes #814

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3bbd996) 98.16% compared to head (e925dbd) 98.16%.

:exclamation: Current head e925dbd differs from pull request most recent head c433937. Consider uploading reports for the commit c433937 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #815 +/- ## ======================================= Coverage 98.16% 98.16% ======================================= Files 34 34 Lines 4460 4461 +1 ======================================= + Hits 4378 4379 +1 Misses 82 82 ``` | [Impacted Files](https://app.codecov.io/gh/Flask-Middleware/flask-security/pull/815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Flask-Middleware) | Coverage Δ | | |---|---|---| | [flask\_security/forms.py](https://app.codecov.io/gh/Flask-Middleware/flask-security/pull/815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Flask-Middleware#diff-Zmxhc2tfc2VjdXJpdHkvZm9ybXMucHk=) | `99.21% <ø> (ø)` | | | [flask\_security/views.py](https://app.codecov.io/gh/Flask-Middleware/flask-security/pull/815?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Flask-Middleware#diff-Zmxhc2tfc2VjdXJpdHkvdmlld3MucHk=) | `98.78% <100.00%> (+<0.01%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.