search

pallets-eco / flask-session

Server side session extension for Flask
https://flask-session.readthedocs.io
BSD 3-Clause "New" or "Revised" License
507 stars 238 forks source link

Fix wekzeug 1.0 compatibility #114

Closed SqrtMinusOne closed 4 years ago

SqrtMinusOne commented 4 years ago

werkzeug.contrib.cache was moved to https://github.com/pallets/cachelib since version 1.0

adeedchoudhury commented 4 years ago

Any update on when this will be merged @SqrtMinusOne ? Thanks!

SqrtMinusOne commented 4 years ago

I have no idea; addressing that to @fengsp. As for now, as the module isn't complicated, I'd suggest taking the parts you need.

rayluo commented 4 years ago

FYI: I encounter same problem, and I fixed it in my fork, and you can install it in this way:

pip install git+https://github.com/rayluo/flask-session.git@0.3.x
m1waterman88 commented 4 years ago

Had the issue causing this PR. Can confirm this PR update fixed the issue for me when manually updating flask_session/sessions.py

rayluo commented 4 years ago

@m1waterman88 Would you mind also try out pip install git+https://github.com/rayluo/flask-session.git@0.3.x to see if it can fix the issue for you WITHOUT needing to manually update the file?

m1waterman88 commented 4 years ago

@m1waterman88 Would you mind also try out pip install git+https://github.com/rayluo/flask-session.git@0.3.x to see if it can fix the issue for you WITHOUT needing to manually update the file?

Since you made the same code change that this PR request has (and thus that I have), yes, it would fix it.

tvb commented 4 years ago

pip install git+https://github.com/rayluo/flask-session.git@0.3.x

I can confirm this fixed it for me too. (using pip3)

m1waterman88 commented 4 years ago

I've reached out to to repo owner twice via email in addition to any actions in the Flask-Session repo, and I haven't received a reply. Between the lack of response and the last commit occurring on Feb 9, 2017, unfortunately I think this repo has been abandoned.

tvb commented 4 years ago

@m1waterman88 I hate it when this happens. Great software gets abandoned at some point and is turning into waste over time. What are our alternatives for flask-session?

m1waterman88 commented 4 years ago

@fengsp, please provide write access so we can keep this repo going. Many use it and would like to continue to do so.

image

We can fork it, sure, but it's easier for projects already routing to this repo to continue to do so.

Thanks.

rayluo commented 4 years ago

Welcome back, @fengsp ! :-D Please release this into 0.3.2 soon!

tvb commented 4 years ago

😱