Replaced deprecated app.session_cookie_name with app.config["SESSION_COOKIE_NAME"].

pallets-eco / flask-session

Server side session extension for Flask

https://flask-session.readthedocs.io

BSD 3-Clause "New" or "Revised" License

501 stars 239 forks source link

Replaced deprecated app.session_cookie_name with app.config["SESSION_COOKIE_NAME"]. #148

Closed imacat closed 1 year ago

fengsp commented 1 year ago

@rayluo It seems this breaks for anyone who is using Flask < 2.3 ?

rayluo commented 1 year ago

Welcome back, @fengsp !

@rayluo It seems this breaks for anyone who is using Flask < 2.3 ?

Not necessarily. Flask-session itself uses semantic versioning. We can have flask-session 0.4.x continue working with Flask < 2.3, and have flask-session 0.5+ using Flask >= 2.2.

imacat commented 1 year ago

@rayluo It seems this breaks for anyone who is using Flask < 2.3 ?

I do not think this is an issue. When we have:

Flask-Session 0.4.x: install_requires: Flask >=0.8, <2.3
Flask-Session 0.5.0: install_requires: Flask >=2.2

People running Flask<2.3 can still use Flask-Session==0.4.x nicely.

davidism commented 1 year ago

Flask-Session 0.5.0 is now available.