prevent save session again + tester + clean code

pallets-eco / flask-session

Server side session extension for Flask

https://flask-session.readthedocs.io

BSD 3-Clause "New" or "Revised" License

490 stars 236 forks source link

prevent save session again + tester + clean code #188

Closed idoshr closed 5 months ago

idoshr commented 9 months ago

Add should_set_cookie for preventing save again session without any change **this is the way flask implement save_session()
remove duplicate code
fix testers

Lxstr commented 6 months ago

Hi @idoshr thanks for the great PR. I have merged along with #179 and other suggestions to development branch for now, while we get feedback on that. If you are able to take a look at it that would be very appreciated.

Lxstr commented 6 months ago

I opted for Pytest over your testing implementation, but your mocking of different redis versions might be useful. How would that potentially look in the Pytest version of #179?

Lxstr commented 6 months ago

Also, I noticed there is the vary header set in flask. I cannot see any reason why we should not also be doing that to prevent accidental caching? @ThiefMaster and @darless, would you have any input here?