search

pallets-eco / flask-session

Server side session extension for Flask
https://flask-session.readthedocs.io
BSD 3-Clause "New" or "Revised" License
488 stars 236 forks source link

DynamoDB backend implementation. #213

Closed necat1 closed 4 months ago

necat1 commented 4 months ago

Hey, i have implemented DynamoDBSessionInterface, and it works locally. How can i create PR? I don't have access to repo.

Lxstr commented 4 months ago

Hi there, you need to create a fork of flask session, push your feature branch (call it dynamodb) to your forked repo then create a pull request (preferably to development branch). Note that there have been quite a few changed on development branch that haven't been merged yet so you may need to rewrite slightly

Lxstr commented 4 months ago

Waiting for your PR. Closing this issue

necat1 commented 4 months ago

Thanks, here is the adapted PR for development branch https://github.com/pallets-eco/flask-session/pull/214 I can also create PR for current main branch, code is ready either way and is smaller than the one in development branch. That is if next release is going to take long time.

Lxstr commented 4 months ago

Looks pretty good. Thanks for also adding the tests. I'll review in detail in the next few days. Next release also in the next few days