DynamoDB: Add table_exists parameter and extend documentation

pallets-eco / flask-session

Server side session extension for Flask

https://flask-session.readthedocs.io

BSD 3-Clause "New" or "Revised" License

488 stars 236 forks source link

Closed MauriceBrg closed 2 months ago

MauriceBrg commented 2 months ago

Add table_exists parameter to DynamoDBSessionInterface (SESSION_DYNAMODB_TABLE_EXISTS) to support pre-existing tables and limited permissions
- Add test to ensure that it works with a pre-existing table
- Add test to ensure there's an error when the table doesn't exist
Extend documentation for DynamoDBSessionInterface
Fix typo in CONTRIBUTING.rst
Fixes https://github.com/pallets-eco/flask-session/issues/240

Lxstr commented 2 months ago

mind if i try a force push?

MauriceBrg commented 2 months ago

Seems like my last commit with the doc fix didn't make it, is the PR still open for you? Maybe you can try to merge again...

Lxstr commented 2 months ago

So strange... but git kraken has done this to me before where it just randomly wont merge something

Lxstr commented 2 months ago

I think i'll reset and try again, using github

Lxstr commented 2 months ago

Does that look, better? I used github but it made a merge back into the PR first, a bit annoying

MauriceBrg commented 2 months ago

Yeah, seems like the latest changes are now in development and it's shown as merged :)