pallets-eco / flask-session

Server side session extension for Flask
https://flask-session.readthedocs.io
BSD 3-Clause "New" or "Revised" License
488 stars 236 forks source link

Testers for session lifetime #238

Open idoshr opened 2 months ago

idoshr commented 2 months ago

Add some testers for:

seems like there is some issues with the lifetime session in:

EDIT:

prevent session hijacking by generate session already exists

MauriceBrg commented 2 months ago

Is your DynamoDB problem maybe related to this? https://github.com/pallets-eco/flask-session/issues/240

idoshr commented 2 months ago

Is your DynamoDB problem maybe related to this? https://github.com/pallets-eco/flask-session/issues/240

I think it is the same issue and we need add filter by expectation time and not relay only on ttl index

MauriceBrg commented 2 months ago

I've added a fix for that issue to this PR - https://github.com/pallets-eco/flask-session/pull/237

Lxstr commented 2 months ago

ok great I will merge #237 first

Lxstr commented 2 months ago

@idoshr I've got #237 merged, should we rebase your PR?

idoshr commented 2 months ago

I will pull development to my branch

idoshr commented 2 months ago

@Lxstr Merged

MauriceBrg commented 2 months ago

I think you should update the target branch to development for this PR

idoshr commented 2 months ago

I think you should update the target branch to development for this PR

Changed now @MauriceBrg @Lxstr

Lxstr commented 2 months ago

Hi @idoshr thanks for your continued work. Could you please remove the code changed in commit 4fb799 as we do have need for this should_set_storage method? Also, can you separate the code you added for regeneration into a new PR? This is out of scope, better to just focus on testing for one PR I think