Open idoshr opened 2 months ago
Is your DynamoDB problem maybe related to this? https://github.com/pallets-eco/flask-session/issues/240
Is your DynamoDB problem maybe related to this? https://github.com/pallets-eco/flask-session/issues/240
I think it is the same issue and we need add filter by expectation time and not relay only on ttl index
I've added a fix for that issue to this PR - https://github.com/pallets-eco/flask-session/pull/237
ok great I will merge #237 first
@idoshr I've got #237 merged, should we rebase your PR?
I will pull development to my branch
@Lxstr Merged
I think you should update the target branch to development for this PR
I think you should update the target branch to development for this PR
Changed now @MauriceBrg @Lxstr
Hi @idoshr thanks for your continued work. Could you please remove the code changed in commit 4fb799 as we do have need for this should_set_storage method? Also, can you separate the code you added for regeneration into a new PR? This is out of scope, better to just focus on testing for one PR I think
Add some testers for:
seems like there is some issues with the lifetime session in:
EDIT:
prevent session hijacking by generate session already exists