pallets-eco / flask-sqlalchemy

Adds SQLAlchemy support to Flask
https://flask-sqlalchemy.palletsprojects.com
BSD 3-Clause "New" or "Revised" License
4.18k stars 896 forks source link

(Bad rebase) Fix issue #1318: Type (typehint) error for `db.relationship` #1319

Closed cainmagi closed 3 months ago

cainmagi commented 3 months ago

Fix the typehint inconsistence of db.relationship(...).

Checklist:

pamelafox commented 3 months ago

It looks like you branched off main, but bugfixes should branch off latest 3.x branch, per https://github.com/pallets-eco/flask-sqlalchemy/blob/main/CONTRIBUTING.rst#start-coding

Can you rebase to branch off that branch instead? Thanks!

cainmagi commented 3 months ago

Sorry for not noticing it! I will try to rebase this PR later.

cainmagi commented 3 months ago

Sorry! It seems that the branch is messed up after rebasing it! I think I should submit a different PR to do this.