search

pallets-eco / wtforms-appengine

WTForms integration for Google App Engine
https://wtforms-appengine.readthedocs.io
Other
42 stars 16 forks source link

Repeated key property fix #13

Closed davidstackio closed 8 years ago

davidstackio commented 9 years ago

Fixes #1 and #6. Integrated #8 PR and fixes from https://github.com/xlevus/wtforms-ndb.

mikelambert commented 8 years ago

So @dhstack, you grabbed from https://github.com/xlevus/wtforms-ndb/commits/master, right? Looks like there's been another dozen commits since you branched it early last year, so ideally I'd be merging some mix of https://github.com/xlevus/wtforms-ndb/commits/master and the changes you made after merging to get it working back within wtforms_appengine.

@dhstack not sure if you're still actively working with wtforms and have any interest in this? Or better yet, @xlevus, not sure if you have any interest in merging your improvements back into wtforms-appengine package and un-forking things? I just recently volunteered to maintain wtforms-appengine, and so have been going through trying to process all the ancient pull requests, hoping I'm not too late... :)

xlevus commented 8 years ago

I'll try and find some time to submit a PR to wtforms-appengine over the next few days. No promises ;)

On 21 December 2015 at 01:40, Mike Lambert notifications@github.com wrote:

So @dhstack https://github.com/dhstack, you grabbed from https://github.com/xlevus/wtforms-ndb/commits/master, right? Looks like there's been another dozen commits since you branched it early last year, so ideally I'd be merging some mix of https://github.com/xlevus/wtforms-ndb/commits/master and the changes you made after merging to get it working back within wtforms_appengine.

@dhstack https://github.com/dhstack not sure if you're still actively working with wtforms and have any interest in this? Or better yet, @xlevus https://github.com/xlevus, not sure if you have any interest in merging your improvements back into wtforms-appengine package and un-forking things? I just recently volunteered to maintain wtforms-appengine, and so have been going through trying to process all the ancient pull requests, hoping I'm not too late... :)

— Reply to this email directly or view it on GitHub https://github.com/wtforms/wtforms-appengine/pull/13#issuecomment-166172105 .

davidstackio commented 8 years ago

@mikelambert Yes, you are correct. I grabbed from https://github.com/xlevus/wtforms-ndb/commits/master a while ago so it looks like you'll need to merge all the changes from there and what I did.

I'm not working with wtforms anymore - moved on to other projects. Best of luck getting everything working :)

mikelambert commented 8 years ago

I'm going to close this one as I just merged in xlevus's other pull request with all the requisite fixes.