Open CanaryWharf opened 3 hours ago
Yeah, I think we could do something similar to itsdangerous here, with a new OLD_SECRET_KEYS
config. Then app.secret_key
remains a single value, and additional values can be added to the new config, and they can be sent to the itsdangerous mechanism. Note that app.config
can't be mutated after startup (as it won't sync across each worker depending on how it's deployed), so updating the keys would require restarting the application.
I'd like to have a couple of secret keys available, like so
To allow them to rotate.
I've seen this issue which seems to have auto-closed https://github.com/pallets/flask/issues/1574
It seems like itsdangerous now supports this https://github.com/pallets/itsdangerous/pull/141
This would allow secret keys to be rotated regularly without sessions being invalidated.