search

pallets / jinja

A very fast and expressive template engine.
https://jinja.palletsprojects.com
BSD 3-Clause "New" or "Revised" License
10.28k stars 1.61k forks source link

include "examples" directory in the sdist again #1982

Open dne opened 4 months ago

dne commented 4 months ago

When moving to flit from setuptools, the "examples" directory was lost from the source distribution. I'm assuming that this was unintentional, since pyproject.toml on the main branch still includes it.

Fixes regression introduced in #1968.

davidism commented 4 months ago

Thanks, but I don't think we need to include them. The examples aren't part of the code docs or tests (and those last two don't technically need to be there either).

dne commented 4 months ago

Sure, they're not strictly necessary, but they've been part of the sdist since version 2.0 up until 3.1.3. And, as I mentioned, this regression seems specific for the 3.1.x branch.

FWIW, I discovered this when packaging 3.1.4 for Alpine Linux, which installs the examples as part of the "doc" sub-package (and so does e.g. Debian apparently)