Accept AsyncIterables being passed to Response

pallets / quart

An async Python micro framework for building web applications.

https://quart.palletsprojects.com

MIT License

3.01k stars 164 forks source link

Closed mjsir911 closed 4 days ago

mjsir911 commented 6 months ago

Fixes pallets/flask#5322

Checklist:

[x] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[x] Add or update relevant docs, in the docs folder and in code.
[ ] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
[ ] Add .. versionchanged:: entries in any relevant code docs.
[ ] Run pre-commit hooks and fix any issues.
[ ] Run pytest and tox, no tests failed.

mjsir911 commented 6 months ago

I want to add tests for this somehow

mjsir911 commented 6 months ago

@davidism ready for review, would like extra eyes on the test specifically

mjsir911 commented 6 months ago

Add an entry in CHANGES.rst summarizing the change and linking to the issue.

I've been told I don't need to do this and it will be gotten to later.

mjsir911 commented 6 months ago

It would be cool if ResponseValue in typing.py could be updated too but adding AsyncIterator[bytes] or similar causes a lot of errors.

CoolCat467 commented 2 weeks ago

Is there anything stopping this from being merged?

pgjones commented 4 days ago

Merged manually in a80358bbe27a10f5ec709760e62ac3930bbedee7 to fix conflict