Use flask default config for Quartz default config, to pull in missing keys

pallets / quart

An async Python micro framework for building web applications.

https://quart.palletsprojects.com

MIT License

3.01k stars 164 forks source link

Use flask default config for Quartz default config, to pull in missing keys #374

Closed JamesParrott closed 5 days ago

JamesParrott commented 5 days ago

fixes #371
drops Python 3.8 (this is needed anyway, but I wanted to use Python 3.9's | operator to combine dictionaries)

davidism commented 5 days ago

The changes here don't seem to match the title. Please don't mix multiple changes in one PR, it makes it hard to review. Keep dropping Python 3.8, typing, and bug fixes separate.

JamesParrott commented 5 days ago

@davidism I appreciate this PR now requires a little more work to understand. But the further changes I made after I first named the PR, thinking the fix would be simple, have enabled the type checking and tests all to pass again for the first time in 6 months.

pgjones commented 5 days ago

See #373