Closed afdy closed 4 months ago
If you already have a fix, then submitting a PR (or at least showing the patch in here) is always a good idea - also because that way we immediately see what (you think) is wrong with our code, which is often much faster than reading a long natural language description ;)
TLS validation on localhost does not work with the auto generated certificate.
To replicate:
dev-cert.crt is generated, but does not work, a sample ERROR using wget:
Certificate looks valid, however I think wget, curl, python requests does not like the cn name?
I've been using this library and running it insecure as a result for a while but today it really bugged me so thought i would dig deeper.
If i generate the certificate manually, it works and validates fine. With minor modifications to serving.py to fix the SANS/CN fields, i can make it work ok:
Environment:
Is this a bug? I could submit a pull request with my local change to serving.py, which appears to resolve?