search

pallets / werkzeug

The comprehensive WSGI web application library.
https://werkzeug.palletsprojects.com
BSD 3-Clause "New" or "Revised" License
6.65k stars 1.73k forks source link

replace pytest-xprocess #2906

Closed davidism closed 2 days ago

davidism commented 5 months ago

Pytest-xprocess has been really helpful to running our dev server tests. But we're not doing anything super complicated, and its API may be adding complexity. And it causes a bunch of resource warnings when pytest ends (luckily these don't count as errors).

I think I had seen a project from @pamelafox that used plain multiprocessing or subprocess to manage a live server directly. See about switching our tests to something like that.

pamelafox commented 5 months ago

I think this is the one you're thinking of: https://github.com/Azure-Samples/azure-flask-postgres-flexible-aca/blob/main/src/tests/local/conftest.py

I believe its now finally working on the Windows test runner, that was what we were trying to fix last time I worked on that project.

On Sat, May 18, 2024 at 8:33 AM David Lord @.***> wrote:

Pytest-xprocess has been really helpful to running our dev server tests. But we're not doing anything super complicated, and its API may be adding complexity. And it causes a bunch of resource warnings when pytest ends (luckily these don't count as errors).

I think I had seen a project from @pamelafox https://github.com/pamelafox that used plain multiprocessing or subprocess to manage a live server directly. See about switching our tests to something like that.

— Reply to this email directly, view it on GitHub https://github.com/pallets/werkzeug/issues/2906 or unsubscribe https://github.com/notifications/unsubscribe-auth/AACIQUUVIO35VO6J4PHWO6DZC5YGJBFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJLJONZXKZNENZQW2ZNLORUHEZLBMRPXI6LQMWBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTLDTOVRGUZLDORPXI6LQMWSUS43TOVS2M5DPOBUWG44SQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLJRZHE3TGMZYQKSHI6LQMWSWS43TOVS2K5TBNR2WLKRSGMYDIMJTG43DKN5HORZGSZ3HMVZKMY3SMVQXIZI . You are receiving this email because you were mentioned.

Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .