Switch to an event allowlist for watchdog

pallets / werkzeug

The comprehensive WSGI web application library.

https://werkzeug.palletsprojects.com

BSD 3-Clause "New" or "Revised" License

6.66k stars 1.73k forks source link

Switch to an event allowlist for watchdog #2947

Closed lociii closed 1 month ago

lociii commented 2 months ago

Ignores the new closed_no_write event type fired by watchdog 5.x that is causing unnecessary reloads.
To prevent such cases in the future, I introduced an event allow list.

fixes https://github.com/pallets/werkzeug/issues/2945

Test case added
Change log added

lociii commented 2 months ago

Can we please get a little speed on this one?
werkzeug is currently broken when using it with django-extensions and not pinning watchdog to a 4.x release.

https://github.com/pallets/werkzeug/issues/2945#issuecomment-2354842482

davidism commented 1 month ago

I had to rebase to change the target from main to stable. Since you opened this PR from your main branch, you'll need to reset it: git fetch upstream && git reset --hard upstream/main. Remember to create pull requests from dedicated branches.