search

pallotron / yubiswitch

OSX status bar application to enable/disable Yubikey Nano
Other
877 stars 65 forks source link

Add option to disable notifications #12

Closed ryanbrainard closed 10 years ago

ryanbrainard commented 10 years ago

This is an implementation of Issue #11 to provide an option to disable notifications. It defaults to displaying the notifications, so there is no change in behavior for existing users.

ryanbrainard commented 10 years ago

When getting my environment setup for this change, I noticed that commit 80ece17 is not valid for ShortcutRecorder. Setting it to master (ecc9e61) seemed to work, but I did not include that submodule update in this pull request since it was unrelated and untested. Just FYI if you want to fix that separately.

pallotron commented 10 years ago

hey, thank you very much for this pull request, I've tested it and it works fine. I've just merged it. I'll look into the ShortcutRecorder issue separately.

ryanbrainard commented 10 years ago

Thanks for the quick merge!