search

pallotron / yubiswitch

OSX status bar application to enable/disable Yubikey Nano
Other
872 stars 65 forks source link

OSX Yosemite "Dark mode" support #19

Closed tekkub closed 9 years ago

tekkub commented 9 years ago

image

Currently, yubiswitch doesn't seem to support the new "dark mode" menu bar in Yosemite. Can you tell where it is in that screenshot? Clearly it's possible to support it (dropbox's latest beta auto-switches), it'd be awesome if yubiswitch were to add support also.

:bear: :heart: :feet:

pallotron commented 9 years ago

I guess it all comes down to the icon I use... I'll take a look. thanks for reporting!

pallotron commented 9 years ago

yeh can you download v0.8 dmg? it should work now with dark mode.

tekkub commented 9 years ago

image

It works, but it could still benefit from a little lightnening or color inversion when dark mode is enabled.

Thanks you for the quick fix. :pig_nose: :yellow_heart:

pallotron commented 9 years ago

uhm, well feel free to submit a pull request, I'm think about two sets of icons then some logic at start up or somehow when dark mode is enabled that switches between them. I dunno when I'll get time to work on it. :(

tekkub commented 9 years ago

Roger. I'll keep an eye out for example code on how to pull this off. it must be possible, dropbox and now 1password are doing it. If I find something I'll open a new issue and try to tweak the icons for you.

pallotron commented 9 years ago

ty!

tekkub commented 9 years ago

So I found this guide. I'm not an obj-C fellow, so I'm not sure if this is a quick and easy fix here or not.

pallotron commented 9 years ago

thanks, I'll keep that in mind whenever I'll find the time :)