search

palmerabollo / game-ladder

The simplest game ladder out there.
2 stars 2 forks source link

Roll Message in event list. #18

Closed labajo closed 11 years ago

labajo commented 11 years ago

Google Chrome

If a players perform two consecutive victories, an extra message appears in the event list.

palmerabollo commented 11 years ago

It's nice, I also thought about it, it is easy (<10 LOC) if we store the number of consecutive wins in the Player object. Assigned to me !

palmerabollo commented 11 years ago

Fixed, shows a star next to the game line when Player.consecutive_wins > ONFIRE_THRESHOLD (configurable, default = 3)

palmerabollo commented 11 years ago

Try to find a better symbol here. I like the skull http://www.danshort.com/HTMLentities/index.php?w=warni

labajo commented 11 years ago

I found several stars in http://www.danshort.com/HTMLentities/index.php?w=dingb(My mobile doesn't support those character). Why do you prefer a dodgy character instead a little image or FontAwesome Icon without bootstrap (http://fortawesome.github.com/Font-Awesome)?

palmerabollo commented 11 years ago

Yes, I like fortawesome icons, too. I've never used them before.

labajo commented 11 years ago

I try to change that character with a font awesome star character.