search

palomachain / paloma

The fast blockchain messenger protocol
Apache License 2.0
291 stars 135 forks source link

hotfix: prevent punishing missing attestants for unhandled msg #1095

Closed byte-bandit closed 8 months ago

byte-bandit commented 8 months ago

Related Github tickets

Background

Some messages might still fail to be handled at all, meaning the message will not even enter the attestation phase. In this case, we do not want to punish validators - otherwise we'd jail the entire network.

Merging this into devel, which was taken from release/v1.12.2. That will be my working branch for a v1.12.3 release in case master remains blocked due to the Cosmos upgrade.

Testing completed

Breaking changes

taariq commented 8 months ago

@byte-bandit minor release will require chain halt. Yes?

byte-bandit commented 8 months ago

@byte-bandit minor release will require chain halt. Yes?

It touches consensus operations, so yes. This will need a full governance update. I will try to squeeze in the next fix for the stuck gravity batch as well.