palomachain / paloma

The fast blockchain messenger protocol
Apache License 2.0
290 stars 136 forks source link

feat: remove retry limit from erc20 transfers #1214

Closed byte-bandit closed 2 months ago

byte-bandit commented 2 months ago

Related Github tickets

Background

This change will make sure that ERC20 transfers are being retried continuously instead of stopping after 2 retries to try and attempt to prevent a deadlock. There might still be a need for a manual unlock down the road.

Additionally, we now make sure to stop processing skyway messages while we have an ongoing contract deployment, to avoid a desync of the nonces on the old and new compass.

Testing completed

Breaking changes

byte-bandit commented 2 months ago

I ultimately decided against the watch dog approach, since we're lacking access to a lot of dynamic information at the EndBlocker, that is naturally available during the attestation process. So instead, we just keep brute forcing the message.

taariq commented 2 months ago

@byte-bandit needs a signed commit to merge.