palomachain / paloma

The fast blockchain messenger protocol
Apache License 2.0
291 stars 135 forks source link

Fix/pigeons attest rolledback txs #1284

Closed maharifu closed 2 months ago

maharifu commented 2 months ago

Related Github tickets

Background

Paloma was attesting to pigeon relayed messages using only the transaction, but not the receipt, meaning it couldn't actually attest the transaction was successful. This (and a corresponding PR in pigeon) makes paloma verify the transaction result from the transaction receipt and only attest to successful transactions.

Validated with an SLC message in the private testnet using Gnosis, but the result should be the same for all turnstone messages. This wasn't replicable in Arbitrum, where messages fail immediately on pigeons.

Also in this PR is a fix for SLC and User Smart Contract Upload retries. We need to clear the Fees from the message before a retry, otherwise we get an Invalid Signature error.

Testing completed

Breaking changes