palomachain / paloma

The fast blockchain messenger protocol
Apache License 2.0
290 stars 135 forks source link

chore: update validator nonces in endblocker #1292

Closed maharifu closed 2 months ago

maharifu commented 2 months ago

Related Github tickets

Background

The way it was before, we would need a claim to be observed so validators would be updated. By doing it in the endblocker, we validators are always up-to-date.

This should prevent a situation where the last claim is 19, the last observed nonce is 18, but validators are stuck on nonce 17. They would receive a list of block events with the block of nonce 19 (latest unobserved) but would be unable to claim it, since skyway would expect them to submit a claim for nonce 18 instead.

Testing completed

Breaking changes