search

palomachain / paloma

The fast blockchain messenger protocol
Apache License 2.0
290 stars 135 forks source link

Keep Alive Failure: out of gas in location: WritePerByte; gasWanted: 128769, gasUsed: 133474: out of gas #1305

Closed taariq closed 1 month ago

taariq commented 1 month ago

What is happening?

Section description Provide as much context as you can. Give as much context as you can to make it easier for the developers to figure what is happening.

Keep Alive Failure: out of gas in location: WritePerByte; gasWanted: 128769, gasUsed: 133474: out of gas See https://paloma.explorers.guru/transaction/B9FB761043481C3178CC5131630E94FB996555E529C2736C21E09ACE48C914F9?height=24462541

Paloma and pigeon versions and logs

Section description Write down paloma version. Write down pigeon version. Copy and paste pigeon config file as well as relevant ENV variables.

Paloma v2.2.2 and Pigeon 2.2.2

How to reproduce?

Section description Please write detailed steps of what you were doing for this bug to appear.

Paloma Pigeon sending Keep Alive messages

What is the expected behaviour?

Section description If you know, please write down what is the expected behaviour. If you don't know, that's ok. We can have a discussion in comments.

Keep alives do not run out of gas.

taariq commented 1 month ago

Fixed with https://github.com/palomachain/pigeon/pull/445

maharifu commented 1 month ago

@taariq This was not fixed in the PR. I will revert these changes in the next PR.

The gas-adjustment value is already configurable on pigeon's config.yaml. The default value is 3.0, but we should set it to be higher now. I'll adjust it in our validator.

taariq commented 1 month ago

@maharifu do all validators need to adjust?

maharifu commented 1 month ago

@maharifu do all validators need to adjust?

@taariq Where is this error coming from? I assumed it was our own validator. If not, they need to check the paloma.gas-adjustment setting in pigeon config and set it to be a bit higher. Other validators might have a different setting altogether.

taariq commented 1 month ago

Good. I'll let the pigeons know. Thank you!