search

palra / univ-mmorpg

0 stars 0 forks source link

Utility of Inventory#getItemByCategory() #21

Closed palra closed 9 years ago

palra commented 9 years ago

https://github.com/palra/univ-mmorpg/blob/feature/serialization/src/main/java/fr/univdevs/mmorpg/engine/character/Inventory.java#L233-L236

Isn't that a (bad) duplicate of Inventory#getByType(String) ?

drattak commented 9 years ago

The name is wrong, but one returns only one item, the first of its category, and the other one returns all categories

palra commented 9 years ago

So Item#getFirstOfCategory(String) ? It looks useless

drattak commented 9 years ago

Indeed, equivalent to getByType[x]

palra commented 9 years ago

So, do we keep it ?

palra commented 9 years ago

So, it's "no"